Skip to content
This repository has been archived by the owner on Mar 25, 2021. It is now read-only.

[bugfix] Completed docs rule can check single-line comments #3841

Merged
merged 3 commits into from
Jul 31, 2018

Conversation

PomanoB
Copy link
Contributor

@PomanoB PomanoB commented Apr 18, 2018

PR checklist

Overview of change:

Completed docs rule can check single-line JSDoc comments

@JoshuaKGoldberg
Copy link
Contributor

Thanks for the PR @PomanoB but there's already a PR out to fix this issue: #3557

@PomanoB
Copy link
Contributor Author

PomanoB commented Apr 23, 2018

Yes, but #3557 is more complex and unknown when it is merged(
Of course, you can close this pull-request if not agree with small fix or #3557 is coming

@giladgray
Copy link

@PomanoB please update this branch so we can review it, or close it if no longer relevant. we will close this if we do not hear from you in two weeks.

@PomanoB
Copy link
Contributor Author

PomanoB commented Jul 30, 2018

@giladgray done.

@giladgray
Copy link

easy enough

@giladgray giladgray merged commit a2fac98 into palantir:master Jul 31, 2018
@PomanoB PomanoB deleted the completed-docs-single-tags-fix branch July 31, 2018 20:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants