Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Gradle 8 #1011

Closed
wants to merge 2 commits into from
Closed

Upgrade to Gradle 8 #1011

wants to merge 2 commits into from

Conversation

mandrean
Copy link

@mandrean mandrean commented Feb 15, 2024

  • Bump Intellij plugins (I get a compilation error otherwise)
  • Bump gradle wrapper to v8.5

Seems to work for me?

❯ cd ~/src/github.com/palantir/palantir-java-format

❯ java -version
openjdk version "21" 2023-09-19 LTS
OpenJDK Runtime Environment Temurin-21+35 (build 21+35-LTS)
OpenJDK 64-Bit Server VM Temurin-21+35 (build 21+35-LTS, mixed mode)

❯ gradle -version
------------------------------------------------------------
Gradle 8.5
------------------------------------------------------------

Build time:   2023-11-29 14:08:57 UTC
Revision:     28aca86a7180baa17117e0e5ba01d8ea9feca598

Kotlin:       1.9.20
Groovy:       3.0.17
Ant:          Apache Ant(TM) version 1.10.13 compiled on January 4 2023
JVM:          21 (Eclipse Adoptium 21+35-LTS)
OS:           Mac OS X 14.3 aarch64

❯ gradle spotlessApply

Deprecated Gradle features were used in this build, making it incompatible with Gradle 9.0.

You can use '--warning-mode all' to show the individual deprecation warnings and determine if they come from your own scripts or plugins.

For more on this, please refer to https://docs.gradle.org/8.5/userguide/command_line_interface.html#sec:command_line_warnings in the Gradle documentation.

BUILD SUCCESSFUL in 532ms
15 actionable tasks: 15 up-to-date

@palantirtech
Copy link
Member

Thanks for your interest in palantir/palantir-java-format, @mandrean! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request.

@mandrean mandrean changed the title gradle8 Upgrade to Gradle 8 Feb 15, 2024
@koppor
Copy link
Contributor

koppor commented Mar 6, 2024

@mandrean A gradle wrapper update also involves updating gradlew, gradlew.sh, and the .jar file. These updates are not included in your PR. - Simply calling the spotlessApply task is not enough. You need to build and test the plugin using ./gradlew check.

My output is:

$ gradle check
Starting a Gradle Daemon (subsequent builds will be faster)

FAILURE: Build failed with an exception.

* Where:
Build file 'C:\git-repositories\palantir-java-format\idea-plugin\build.gradle' line: 18

* What went wrong:
A problem occurred evaluating project ':idea-plugin'.
> Failed to apply plugin 'org.jetbrains.intellij'.
   > Could not create task ':idea-plugin:buildPlugin'.
      > 'void org.gradle.api.internal.artifacts.publish.ArchivePublishArtifact.<init>(org.gradle.api.tasks.bundling.AbstractArchiveTask)'

* Try:
> Run with --stacktrace option to get the stack trace.
> Run with --info or --debug option to get more log output.
> Run with --scan to get full insights.
> Get more help at https://help.gradle.org.

Deprecated Gradle features were used in this build, making it incompatible with Gradle 9.0.

You can use '--warning-mode all' to show the individual deprecation warnings and determine if they come from your own scripts or plugins.

For more on this, please refer to https://docs.gradle.org/8.5/userguide/command_line_interface.html#sec:command_line_warnings in the Gradle documentation.

BUILD FAILED in 17s

Note that I used my installed gradle version 8.5.

@koppor
Copy link
Contributor

koppor commented Mar 6, 2024

@mandrean Please create a pull request on your own repository (https://github.com/mandrean/palantir-java-format/pulls). Then, you GitHub actions of this repository will run. I am curious what the Gradle Wrapper Validation Action will say...

Update OMG, the validator validates the .jar only -- gradle/wrapper-validation-action#16

@koppor
Copy link
Contributor

koppor commented Mar 6, 2024

Related: Automatic update of gradle wrapper: #995

@CRogers
Copy link
Contributor

CRogers commented May 2, 2024

Automation upgraded to Gradle 8: #1028

@CRogers CRogers closed this May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants