Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[do not merge] Migrate WebApplicationExceptions to ServiceException #985

Draft
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

carterkozak
Copy link
Contributor

@carterkozak carterkozak commented Oct 20, 2019

Is gradle-baseline the right place for this type of check?

It would be dangerous to recommend making this migration on all projects, as it would be problematic for any project using a jaxrs implementation (jersey, resteasy) without a registered conjure runtime.

==COMMIT_MSG==
Migrate WebApplicationExceptions to ServiceException
==COMMIT_MSG==

@changelog-app
Copy link

changelog-app bot commented Oct 20, 2019

Generate changelog in changelog/@unreleased

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

Implement PreferConjureExceptions error prone checker which is OFF by default to avoid flagging projects which do not use conjure infrastructure. This check can be leveraged to automatically migrate away from common jax-rs exceptions to conjure equivalents.

Check the box to generate changelog(s)

  • Generate changelog entry

This provides a new `PreferConjureExceptions` error prone checker
which is OFF by default to avoid flagging projects which do not
use conjure infrastructure.
@carterkozak carterkozak force-pushed the ckozak/jaxrs_to_conjure_exception_migration branch from 54c7ee6 to a11cf5e Compare October 21, 2019 14:11
@stale
Copy link

stale bot commented Nov 4, 2019

This PR has been automatically marked as stale because it has not been touched in the last 14 days. If you'd like to keep it open, please leave a comment or add the 'long-lived' label, otherwise it'll be closed in 7 days.

@stale stale bot added the stale label Nov 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant