Fork DeterministicScheduler to support nanoseconds #459
+427
−93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carterkozak
commented
Feb 28, 2020
| TimeUnit.MICROSECONDS.convert(difference, TimeUnit.NANOSECONDS)); | ||
| return; | ||
| throw new SafeIllegalStateException( | ||
| "Time rewind - this is likely a bug in the test harness", SafeArg.of("difference", difference)); |
There was a problem hiding this comment.
No more wiggle room.
This prevents us from attempting to go back in time. Without allowing small time-slip we can build confidence that new functionality doesn't cause us to regress. Fork will be unnecessary if the upstream fix is accepted: jmock-developers/jmock-library#172 jmock-developers/jmock-library#173
carterkozak
force-pushed
the
ckozak/custom_scheduler
branch
from
8519b08
to
56f179a
Compare
ferozco
approved these changes
Mar 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents us from attempting to go back in time. Without allowing
small time-slip we can build confidence that new functionality doesn't
cause us to regress.
Fork will be unnecessary if the upstream fix is accepted:
jmock-developers/jmock-library#172
jmock-developers/jmock-library#173
==COMMIT_MSG==
Fork DeterministicScheduler to support nanoseconds
==COMMIT_MSG==