[CASSANDRA-15439] Add option to override the FatClient timeout for Bootstrapping nodes #483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhuffy
force-pushed
the
rh/bootstrapping-fatclient-timeout
branch
from
0c44e64
to
5d8efda
Compare
|
committed to trunk here: apache/cassandra@057d082 |
rhuffy
force-pushed
the
rh/bootstrapping-fatclient-timeout
branch
3 times, most recently
from
4d1e42c
to
73b7187
Compare
…otstrapping nodes
rhuffy
force-pushed
the
rh/bootstrapping-fatclient-timeout
branch
from
73b7187
to
fc73cbc
Compare
zpear
reviewed
May 10, 2024
| @@ -79,6 +81,8 @@ public class VersionedValue implements Comparable<VersionedValue> | |||
|
|
|||
| // values for ApplicationState.REMOVAL_COORDINATOR | |||
| public final static String REMOVAL_COORDINATOR = "REMOVER"; | |||
| public final static List<String> BOOTSTRAPPING_STATES = Arrays.asList(VersionedValue.STATUS_BOOTSTRAPPING, | |||
There was a problem hiding this comment.
nit: status to match the upstream patch?
zpear
approved these changes
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of CASSANDRA-15439
This allows us to override the timeout for node removal while a node is bootstrapping. We know that we never want a bootstrapping node that has been removed by other nodes while streaming to succeed bootstrapping, and have already implemented safeguards to prevent that node from joining the ring after completing streaming.
Setting this parameter to a higher value makes this error state less likely to occur. This change takes the default set in 5.0, which is 5 minutes. We could consider making this higher.
We also had success reducing the frequency of this issue by vertically upsizing nodes and throttling streaming.