Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core fix(Menu Item): Add subMenuCaretTitle field to MenuItemProps #6791

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

ERogalla
Copy link

Checklist

  • Includes tests
  • Update documentation

Changes proposed in this pull request:

The Open Sub Menu title is not derived from any user controlled props. This means we can't internationalize it.

A new subMenuCaretTitle prop was added to the MenuItemsProp.

Reviewers should focus on:

Screenshot

New Docs:
Screenshot 2024-05-10 at 4 46 19 PM

Caret title in question:
Screenshot 2024-05-10 at 4 21 40 PM

@changelog-app
Copy link

changelog-app bot commented May 10, 2024

Generate changelog in packages/core/changelog/@unreleased

What do the change types mean?
  • feature: A new feature of the service.
  • improvement: An incremental improvement in the functionality or operation of the service.
  • fix: Remedies the incorrect behaviour of a component of the service in a backwards-compatible way.
  • break: Has the potential to break consumers of this service's API, inclusive of both Palantir services
    and external consumers of the service's API (e.g. customer-written software or integrations).
  • deprecation: Advertises the intention to remove service functionality without any change to the
    operation of the service itself.
  • manualTask: Requires the possibility of manual intervention (running a script, eyeballing configuration,
    performing database surgery, ...) at the time of upgrade for it to succeed.
  • migration: A fully automatic upgrade migration task with no engineer input required.

Note: only one type should be chosen.

How are new versions calculated?
  • ❗The break and manual task changelog types will result in a major release!
  • 🐛 The fix changelog type will result in a minor release in most cases, and a patch release version for patch branches. This behaviour is configurable in autorelease.
  • ✨ All others will result in a minor version release.

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

Allow "Open Sub Menu" title overrides

Check the box to generate changelog(s)

  • Generate changelog entry

@ERogalla ERogalla changed the title Allow "Open Sub Menu" title overrides core fix(Menu Item): Add subMenuCaretTitle field to MenuItemProps May 10, 2024
@svc-palantir-github
Copy link

Add generated changelog entries

Build artifact links for this commit: documentation | landing | table | demo

This is an automated comment from the deploy-preview CircleCI job.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants