-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix DateRangeInput3 closing on time change in Examples #6782
base: develop
Are you sure you want to change the base?
Conversation
Generate changelog in
|
but i ran prettier... and yarn lint-fix... and yarn formatBuild artifact links for this commit: documentation | landing | table | demoThis is an automated comment from the deploy-preview CircleCI job. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for spotting this and digging in to where the bug is, @moon1ock!
I don't think we should merge this docs change, though. I'd like the docs to continue to represent the "good" / expected ways that people should use components, rather than make it seem like this bug is an expected part of our API.
I recognize that's not a very satisfying answer since we haven't fixed the bug itself yet, but I'm glad you found a workaround that should work for you in your codebase at least. 🙂
this.props.timePrecision
which is supposed to be an alias forthis.props.timePickerProps.precision
seems to be never set and is always null.I tried going down the rabbit hole to figure out how to update it properly, but it's just a can of worms.
Contributing a solution to the docs: it's not elegant, but it works