Add layout engine icons #6705
Open
Add layout engine icons #6705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 9, 2024 14:23
hijiajiajiajia
commented
Feb 9, 2024
| "displayName": "Two column view", | ||
| "iconName": "2-column-view", | ||
| "tags": "presentation, arrangement, layout, two, grid, columns", | ||
| "group": "interface", |
There was a problem hiding this comment.
not sure if "interface" is the most appropriate group here
renameBuild artifact links for this commit: documentation | landing | table | demoThis is an automated comment from the deploy-preview CircleCI job. |
adidahiya
suggested changes
Feb 13, 2024
| }, | ||
| { | ||
| "displayName": "Two column view", | ||
| "iconName": "two-column-view", |
There was a problem hiding this comment.
I think it would be better if all these new icons started with a layout- prefix so that they could be auto-completed / auto-suggested in a more intuitive way. Then I think you could also drop the -view suffix. Something like this:
layout-two-columns
layout-two-rows
layout-three-columns
layout-three-rows
layout-bottom-row-two-tiles
...
Note that you'll also have to update all the .svg file names after you edit "iconName" fields in this JSON file.
| "displayName": "Two column view", | ||
| "iconName": "2-column-view", | ||
| "tags": "presentation, arrangement, layout, two, grid, columns", | ||
| "group": "interface", |
adidahiya
suggested changes
Feb 13, 2024
| <path d="M1 0C0.447716 -2.41411e-08 2.42698e-07 0.447715 2.18557e-07 1L0 6C-2.41411e-08 6.55228 0.447715 7 1 7L15 7C15.5523 7 16 6.55229 16 6V1C16 0.447716 15.5523 6.36101e-07 15 6.1196e-07L1 0Z" fill="black"/> | ||
| </g> | ||
| <defs> | ||
| <clipPath id="clip0_279_19905"> |
There was a problem hiding this comment.
these clip paths on many of the icons are causing rendering issues on the page (see docs preview), please remove all extraneous SVG markup from these files:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add layout engine icons