Upgrade assertj 3.20.1 & safe-logging 1.15.0 #5511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests are failing due to assertj regression in 3.20.0 with map entry comparisons, see assertj/assertj#2264 & fix assertj/assertj#2265 Going to push up a temporary workaround for now to get tests green and unblock |
AssertJ 3.20.0 has a regression with
MapAssert.containsExactlyInAnyOrderEntriesOf where Map values are not
compared with deep-equality on values (e.g. byte arrays).
assertj/assertj#2264
assertj/assertj#2265
Jolyon-S
approved these changes
Jun 18, 2021
|
Released 0.358.0 |
jeremyk-91
reviewed
Jun 18, 2021
| @@ -1 +1 @@ | |||
| 1.8 | |||
| 11 | |||
There was a problem hiding this comment.
This just affects jenv for local gradle tasks, but without this I was getting errors running locally
schlosna
added a commit
that referenced
this pull request
Jun 20, 2021
Assertj 3.20.0 & 3.20.1 had bad ABI compatibility breaks in assertj/assertj#2173 (see #5511 ) and was reverted in assertj/assertj@9df530d4b375b42e7007ae6470604532d435a5cdA and released as assertj 3.20.2.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goals (and why):
Assertj 3.20.0 has some binary compatibility breaks for a number of methods that triggers
NoSuchMethodErrorfor downstream atlasdb consumers.Examples:
Implementation Description (bullets): Bump versions
Testing (What was existing testing like? What have you done to improve it?):
Concerns (what feedback would you like?):
Where should we start reviewing?:
Priority (whenever / two weeks / yesterday): Soon as this prevents downstream bumps