Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PPD-243] Helm, Dockefile and CD Pipeline #2

Merged
merged 34 commits into from Jul 25, 2022
Merged

[PPD-243] Helm, Dockefile and CD Pipeline #2

merged 34 commits into from Jul 25, 2022

Conversation

jacopocarlini
Copy link
Contributor

@jacopocarlini jacopocarlini commented Jul 21, 2022 •
edited

depends on #1

List of Changes

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@jacopocarlini
Copy link
Contributor Author

jacopocarlini commented Jul 21, 2022 •
edited

Warnings
⚠️ This PR changes a total of 473 LOCs, that is more than a reasonable size of 250. Consider splitting the pull request into smaller ones.
⚠️ Please include a Pivotal story at the beginning of the PR title (see below).
Messages
📖 🎉 - congrats on your new release

Example of PR titles that include pivotal stories:

  • single story: [#123456] my PR title
  • multiple stories: [#123456,#123457,#123458] my PR title

Generated by 🚫 dangerJS against 5a17355

jacopocarlini and others added 5 commits July 21, 2022 12:59
@jacopocarlini jacopocarlini self-assigned this Jul 22, 2022
@dpulls
Copy link

dpulls bot commented Jul 22, 2022

🎉 All dependencies have been resolved !

pasqualespica
pasqualespica approved these changes Jul 22, 2022
View reviewed changes
Copy link
Contributor

@pasqualespica pasqualespica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work 🥇

@jacopocarlini
Merge branch 'main' into PPD-243-creazione-infra-microservizio-donazi…
eb94184 
…oni-pipelines-cd

# Conflicts:
#	package.json
@jacopocarlini
Merge remote-tracking branch 'origin/PPD-243-creazione-infra-microser…
66f4893 
…vizio-donazioni-pipelines-cd' into PPD-243-creazione-infra-microservizio-donazioni-pipelines-cd
@jacopocarlini jacopocarlini marked this pull request as ready for review July 25, 2022 12:25
@jacopocarlini jacopocarlini requested review from a team, aomegax and giovanniberti July 25, 2022 12:25
@jacopocarlini jacopocarlini merged commit b8c0bad into main Jul 25, 2022
@jacopocarlini jacopocarlini deleted the PPD-243-creazione-infra-microservizio-donazioni-pipelines-cd branch August 2, 2022 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pasqualespica pasqualespica pasqualespica approved these changes

@aomegax aomegax Awaiting requested review from aomegax

@giovanniberti giovanniberti Awaiting requested review from giovanniberti

Assignees

@jacopocarlini jacopocarlini

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jacopocarlini @pasqualespica