fix(Platform): [IOAPPFD0-12] Fix Android bundling #4160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pagopa-github-bot
changed the title
Affected stories
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #4160 +/- ##
=======================================
Coverage 47.61% 47.61%
=======================================
Files 1275 1275
Lines 25181 25181
Branches 6601 6601
=======================================
Hits 11990 11990
Misses 13141 13141
Partials 50 50 Continue to review full report at Codecov.
|
francescopersico
changed the title
LazyAfternoons
added a commit
that referenced
this pull request
Mar 12, 2024
> [!warning] > Depends on #5506 ## Short description This PR updates the `build.gradle` file and removes a few workarounds which are not needed anymore after the upgrade to RN 0.70. ## List of changes proposed in this pull request - Removes `exclusiveContent` section, added in [this PR](#4160) to address an issue with `react-native`. Patched for version >`0.63` as indicated in the [related issue](facebook/react-native#35210). - Removes `mavenLocal()` repository which doesn't appear to be included by default in the `build.gradle` since a few `react-native` version; - Removes `configurations.all` section which was added by [this PR](https://github.com/pagopa/io-app/pull/267/files) for a dependency, `react-native-camera`, which we don't use anymore. ## How to test We should be able to build Android. Test it by running: ``` cd android && ./gradlew clean && cd .. yarn run-android ``` --------- Co-authored-by: Cristiano Tofani <cri.tofani@gmail.com> Co-authored-by: Mario Perrotta <mario.perrotta@pagopa.it> Co-authored-by: Fabio Bombardi <16268789+shadowsheep1@users.noreply.github.com> Co-authored-by: Federico Mastrini <federicomastrini93@gmail.com> Co-authored-by: Damiano Plebani <damiano.plebani@pagopa.it> Co-authored-by: Alice Di Rico <83651704+Ladirico@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
Fix problem described here with the solution proposed here.
List of changes proposed in this pull request
How to test