Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[B2BP-310] Enable coverage on tests #171

Merged
merged 2 commits into from Feb 21, 2024
Merged

[B2BP-310] Enable coverage on tests #171

merged 2 commits into from Feb 21, 2024

Conversation

kin0992
Copy link
Contributor

@kin0992 kin0992 commented Feb 12, 2024

Enable coverage report.

Warning

The cloudfront-functions app uses rewire to run tests. This dependency is necessary because the AWS runtime doesn't allow the keyword export, so we need to use rewire.
Unfortunately there is an open issue with rewire that causes a 0% coverage, even if there are tests.

List of Changes

Execute tests generating also the coverage report.

  • Enable coverage in nextjs-website

Motivation and Context

We want to monitor the coverage.

Types of changes

  • Chore (nothing changes by a user perspective)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@kin0992 kin0992 requested a review from a team as a code owner February 12, 2024 11:28
Copy link

changeset-bot bot commented Feb 12, 2024

🦋 Changeset detected

Latest commit: ce5f516

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
nextjs-website Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

Jira Pull Request Link

This Pull Request refers to the following Jira issue B2BP-310

@kin0992 kin0992 merged commit 274100c into main Feb 21, 2024
9 checks passed
@kin0992 kin0992 deleted the features/enable-coverage branch February 21, 2024 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants