Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): clean up workflow jobs #199

Merged
merged 4 commits into from May 28, 2022
Merged

chore(ci): clean up workflow jobs #199

merged 4 commits into from May 28, 2022

Conversation

tie
Copy link
Collaborator

@tie tie commented May 27, 2022

This change cleans up CI workflow jobs. It uses the new go-version-file and cache inputs for actions/setup-go.

We also split workflows that contain multiple Go cache steps just to be safe since IIRC cache keys are workflow-scoped, not job scoped, and setup-go does not use a job name for the cache key.

The following key cache will be used: ${{ runner.os }}-go${{ go-version }}-${{ hashFiles('<go.sum-path>') }}

See also actions/setup-go#228 and actions/setup-go#62.

tie added 3 commits May 28, 2022 23:51
The revive linter does not support type parameters with receiver-naming.
See mgechev/revive#669

Uh, also for some reason this bug is marked as a feature request.
@tie tie merged commit fa9f353 into pact-im:main May 28, 2022
@tie tie deleted the go-cache branch May 28, 2022 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant