Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support Alpine #613

Merged
merged 4 commits into from
May 18, 2024
Merged

feat: Support Alpine #613

merged 4 commits into from
May 18, 2024

Conversation

tienvx
Copy link
Contributor

@tienvx tienvx commented May 14, 2024

Thanks @YOU54F for the implementation. Here is the original code master...YOU54F:pact-php:tx-support-alpine

We will need to update the Alpine ci once Github Actions Linux ARM is available.

@coveralls
Copy link

coveralls commented May 14, 2024

Pull Request Test Coverage Report for Build 9136030517

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 97.313%

Totals Coverage Status
Change from base Build 9098735715: 0.0%
Covered Lines: 2282
Relevant Lines: 2345

💛 - Coveralls

@tienvx tienvx force-pushed the support-alpine branch 2 times, most recently from 0df5525 to 2944deb Compare May 14, 2024 04:05
README.md Outdated Show resolved Hide resolved
@tienvx tienvx marked this pull request as ready for review May 17, 2024 02:12
@tienvx tienvx requested a review from YOU54F May 17, 2024 11:10
.github/workflows/build.yml Outdated Show resolved Hide resolved
Copy link
Member

@YOU54F YOU54F left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 Let there be Alpine!

Nice to be first of the client libraries consuming the FFI to support it properly.

edit: I'll get the plugin index updated shortly (probably in about an hour as have a meeting now) - now done ✅

@tienvx tienvx merged commit 7f59cdc into pact-foundation:master May 18, 2024
29 checks passed
@tienvx tienvx deleted the support-alpine branch May 18, 2024 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants