-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pact_ffi library targeting ffi branch for beta use by users #323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MockServerConfig defaults and pact-php speed enhancements
Feat: ARM64 Support for OSX / Linux + Windows 32 bit support
…asing docs: releasing instructions
…ndabot deps(ci): create dependabot config
YOU54F
changed the title
Ffi
pact_ffi library targeting ffi branch for beta use by users
Jul 18, 2023
I've pushed these changes up to https://github.com/YOU54F/simple-pact/pull/1/files
Couple of minor snags so far
Still to test out the consumer side but looking awesome and so quick! |
- add libffi-dev - add php-ffi ext
Tested out the pact-plugins |
This was referenced Jul 24, 2023
YOU54F
added a commit
that referenced
this pull request
Jul 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a continuation of the awesome work done by @tienvx
Should hopefully contain all of your merge commits from the FFI PR's described in #262
Additional changes include
Nice work @tienvx - Looking forward to getting this merged into the
ffi
branch for users to test out, and provide feedback.I've found some php repos in the wild, so going to see if I can spend some time getting them running, and then update them to use this version, and it will provide a nice delta.
@tienvx Happy if you'd prefer to provide a singular pull request rebased against the
ffi
branch and I can close this off - just had some time and this was helpful to me to review all the pieces in situ