Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes for EPEL 8 #1047

Merged
merged 2 commits into from
Dec 9, 2020
Merged

Changes for EPEL 8 #1047

merged 2 commits into from
Dec 9, 2020

Conversation

nforro
Copy link
Member

@nforro nforro commented Dec 8, 2020

Related to issue #278.

  • Make packit work with pyyaml < 5.1
  • Use contextlib.suppress instead of contextlib.nullcontext

@nforro
Make packit work with pyyaml < 5.1
eafcb21 
See: yaml/pyyaml#199

Signed-off-by: Nikola Forró <nforro@redhat.com>
@nforro
Use contextlib.suppress instead of contextlib.nullcontext
82a6d92 
contextlib.suppress with no arguments acts equivalently to
contextlib.nullcontext, except that it doesn't return anything
from __enter__(), but that's not an issue in this case.

contextlib.nullcontext doesn't exist until Python 3.7, this change
allows to run the test suite with Python 3.6.

Signed-off-by: Nikola Forró <nforro@redhat.com>
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

jpopelka
jpopelka approved these changes Dec 8, 2020
View reviewed changes
Copy link
Member

@jpopelka jpopelka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thank you Nikola!

@jpopelka
Copy link
Member

jpopelka commented Dec 8, 2020

/packit build

@packit-as-a-service-stg
Copy link

Congratulations! One of the builds has completed. 🍾

⚠️ Please note that our current plans include removal of these comments in the near future (at least 2 weeks after including this disclaimer), if you have serious concerns regarding their removal or would like to continue receiving them please reach out to us. ⚠️

You can install the built RPMs by following these steps:

  • sudo yum install -y dnf-plugins-core on RHEL 8
  • sudo dnf install -y dnf-plugins-core on Fedora
  • dnf copr enable packit/packit-packit-1047-stg
  • And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

lachmanfrantisek
lachmanfrantisek approved these changes Dec 9, 2020
View reviewed changes
Copy link
Member

@lachmanfrantisek lachmanfrantisek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@lachmanfrantisek lachmanfrantisek added the mergeit When set, zuul wil gate and merge the PR. label Dec 9, 2020
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 3e71502 into packit:master Dec 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpopelka jpopelka jpopelka approved these changes

@lachmanfrantisek lachmanfrantisek lachmanfrantisek approved these changes

Assignees
No one assigned
Labels
mergeit When set, zuul wil gate and merge the PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nforro @jpopelka @lachmanfrantisek