Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip ansible-lint in pre-commit.ci since it is too huge #211

Merged
merged 1 commit into from May 27, 2021
Merged

Skip ansible-lint in pre-commit.ci since it is too huge #211

merged 1 commit into from May 27, 2021

Conversation

lachmanfrantisek
Copy link
Member

  • With ansible-lint pre-commit.ci does not work at all.
  • We still have zuul to run the whole suite.

Signed-off-by: Frantisek Lachman flachman@redhat.com

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

@jpopelka
Copy link
Member

Hmm, the pre-commit.ci is still failing, but from the log, I'd say it fails when installing it.

@lachmanfrantisek
Copy link
Member Author

Hmm, the pre-commit.ci is still failing, but from the log, I'd say it fails when installing it.

I hoped that skip the installation as well. I'll create an issue for that.

@lachmanfrantisek
Copy link
Member Author

Looks like stages does not help with that as well...;(

But on a positive note: It's already implemented in pre-commit itself so we only need to wait for this change to make it to CI.

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

jpopelka
jpopelka approved these changes May 21, 2021
View reviewed changes
Copy link
Member

@jpopelka jpopelka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, you have my ack

@lachmanfrantisek lachmanfrantisek added the do-not-merge Work in progress. label May 24, 2021
@lachmanfrantisek
Copy link
Member Author

Resume:

@lachmanfrantisek
Skip ansible-lint in pre-commit.ci since it is too huge
8e950eb 
* With ansible-lint pre-commit.ci does not work at all.
* We still have zuul to run the whole suite.

Signed-off-by: Frantisek Lachman <flachman@redhat.com>
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

@lachmanfrantisek lachmanfrantisek removed the do-not-merge Work in progress. label May 26, 2021
@lachmanfrantisek
Copy link
Member Author

pre-commit.ci run

@lachmanfrantisek lachmanfrantisek added the mergeit When set, zuul wil gate and merge the PR. label May 27, 2021
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 0ddba51 into packit:main May 27, 2021
@lachmanfrantisek lachmanfrantisek deleted the skip-ansible-lint-in-ci branch May 27, 2021 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpopelka jpopelka jpopelka approved these changes

Assignees
No one assigned
Labels
mergeit When set, zuul wil gate and merge the PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lachmanfrantisek @jpopelka