-
-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow applying fixes on push events #487
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thanks a lot for your contribution :)
@vkucera there is an update to add to cspell.json before I can merge :) (you can just take generated cspell.json file in Mega-Linter artifacts then commit & push ) |
Codecov Report
@@ Coverage Diff @@
## master #487 +/- ##
==========================================
+ Coverage 87.07% 87.34% +0.27%
==========================================
Files 127 127
Lines 2956 2956
==========================================
+ Hits 2574 2582 +8
+ Misses 382 374 -8
Continue to review full report at Codecov.
|
Hi @nvuillam , I modified also other occurrences of the same condition in files that I had overlooked initially. Can you please check that the changes are appropriate? |
I'm quite sure node14 will be ok :) |
Done! :-) |
@vkucera all good, thanks a lot for your contribution and your updates, and welcome to the team :) |
Thanks! |
Partially fixes issue #481
Proposed Changes
so that it can be satisfied for push events.
Readiness Checklist
Author/Contributor
Reviewing Maintainer
breaking
if this is a large fundamental changeautomation
,bug
,documentation
,enhancement
,infrastructure
, orperformance