Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve secret variables management #2611

Merged
merged 28 commits into from
May 12, 2023
Merged

Conversation

nvuillam
Copy link
Member

@nvuillam nvuillam commented May 3, 2023

SECURED_ENV_VARIABLES: add more variables to hide values
SECURED_ENV_VARIABLES_DEFAULT: list of default ignored vars, not recommended to override

@nvuillam
Copy link
Member Author

nvuillam commented May 3, 2023

🦙 MegaLinter status: ⚠️ WARNING

Descriptor Linter Files Fixed Errors Elapsed time
✅ BASH bash-exec 6 0 0.01s
✅ BASH shellcheck 6 0 0.15s
✅ BASH shfmt 6 0 0 0.38s
✅ COPYPASTE jscpd yes no 4.16s
✅ DOCKERFILE hadolint 117 0 19.64s
✅ JSON eslint-plugin-jsonc 23 0 0 3.58s
✅ JSON jsonlint 21 0 0.24s
✅ JSON v8r 23 0 17.57s
⚠️ MARKDOWN markdownlint 313 0 232 157.93s
✅ MARKDOWN markdown-link-check 313 0 6.82s
✅ MARKDOWN markdown-table-formatter 313 0 0 21.74s
✅ OPENAPI spectral 1 0 1.63s
⚠️ PYTHON bandit 191 58 2.46s
✅ PYTHON black 191 0 0 5.27s
✅ PYTHON flake8 191 0 2.12s
✅ PYTHON isort 191 0 0 0.9s
✅ PYTHON mypy 191 0 9.95s
✅ PYTHON pylint 191 0 15.17s
⚠️ PYTHON pyright 191 297 23.22s
✅ PYTHON ruff 191 0 0 0.55s
✅ REPOSITORY checkov yes no 40.61s
✅ REPOSITORY git_diff yes no 0.39s
✅ REPOSITORY secretlint yes no 17.98s
✅ REPOSITORY trivy yes no 32.09s
✅ SPELL cspell 619 0 34.98s
⚠️ SPELL vale 222 61 49.57s
✅ XML xmllint 3 0 0 0.4s
✅ YAML prettier 157 0 0 5.66s
✅ YAML v8r 99 0 155.87s
✅ YAML yamllint 158 0 1.77s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

@nvuillam nvuillam force-pushed the features/default-secured-vars branch 3 times, most recently from be8b352 to 53b0b24 Compare May 11, 2023 19:13
quick build
TEST_KEYWORDS=mega_linter_1_test
@nvuillam nvuillam force-pushed the features/default-secured-vars branch from 53b0b24 to 29e19ee Compare May 11, 2023 19:20
@nvuillam nvuillam force-pushed the features/default-secured-vars branch from 420a639 to d7886e5 Compare May 11, 2023 20:30
@nvuillam nvuillam mentioned this pull request May 11, 2023
@nvuillam
Copy link
Member Author

nvuillam commented May 11, 2023

🦙 MegaLinter status: ⚠️ WARNING

Descriptor Linter Files Fixed Errors Elapsed time
✅ BASH bash-exec 6 0 0.01s
✅ BASH shellcheck 6 0 0.15s
✅ BASH shfmt 6 0 0 0.05s
✅ COPYPASTE jscpd yes no 4.41s
✅ DOCKERFILE hadolint 117 0 17.39s
✅ JSON eslint-plugin-jsonc 23 0 0 3.12s
✅ JSON jsonlint 21 0 0.23s
✅ JSON npm-package-json-lint yes no 0.71s
✅ JSON v8r 23 0 17.03s
⚠️ MARKDOWN markdownlint 313 2 232 155.05s
✅ MARKDOWN markdown-link-check 313 0 6.93s
✅ MARKDOWN markdown-table-formatter 313 2 0 21.96s
✅ OPENAPI spectral 1 0 1.44s
⚠️ PYTHON bandit 191 58 2.57s
✅ PYTHON black 191 0 0 5.08s
✅ PYTHON flake8 191 0 2.04s
✅ PYTHON isort 191 0 0 0.54s
✅ PYTHON mypy 191 0 9.25s
✅ PYTHON pylint 191 0 13.95s
⚠️ PYTHON pyright 191 298 22.92s
✅ PYTHON ruff 191 0 0 0.14s
✅ REPOSITORY checkov yes no 38.27s
⚠️ REPOSITORY devskim yes 913 5.51s
✅ REPOSITORY dustilock yes no 2.08s
✅ REPOSITORY git_diff yes no 0.06s
✅ REPOSITORY secretlint yes no 16.97s
✅ REPOSITORY syft yes no 1.27s
✅ REPOSITORY trivy yes no 29.61s
✅ SPELL cspell 632 0 28.63s
⚠️ SPELL vale 222 61 46.02s
✅ XML xmllint 3 0 0 0.03s
✅ YAML prettier 157 0 0 4.95s
✅ YAML v8r 99 0 145.7s
✅ YAML yamllint 158 0 1.74s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

@nvuillam nvuillam merged commit 6b59e36 into main May 12, 2023
124 checks passed
@nvuillam nvuillam deleted the features/default-secured-vars branch May 12, 2023 04:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant