Use libnet crate for grabbing link info. #304
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pfmooney
reviewed
Jan 24, 2023
Comment on lines
+60
to
+78
| let info = | ||
| libnet::get_link(&libnet::LinkHandle::Name(vnic_name.to_string())) | ||
| .map_err(|e| { | ||
| io::Error::new( | ||
| io::ErrorKind::Other, | ||
| format!("failed to get link info: {e}"), | ||
| ) | ||
| })?; | ||
|
|
||
| let mtu = if let Some(mtu) = info.mtu { | ||
| Some(u16::try_from(mtu).map_err(|_| { | ||
| io::Error::new( | ||
| io::ErrorKind::Other, | ||
| format!("MTU too large: {mtu}"), | ||
| ) | ||
| })?) | ||
| } else { | ||
| None | ||
| }; |
There was a problem hiding this comment.
If we want to keep propolis able to build (albeit useless binaries) on non-illumos platforms, perhaps we can wrap the libnet stuff pulled out into a function in cfg blocks?
|
Since @rmustacc pointed out that the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoids just shelling out to
dladmand some vnic-specific methods to work with other link classes.