[6/n] [dropshot-endpoint] add extra validation for parameters #1011
+676
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created using spr 1.3.6-beta.1
sunshowers
changed the title
Created using spr 1.3.6-beta.1
Created using spr 1.3.6-beta.1
sunshowers
changed the title
ahl
approved these changes
May 31, 2024
|
|
||
| /// A representation of the RequestContext type. | ||
| #[derive(Clone, Eq, PartialEq)] | ||
| enum RqctxTy<'ast> { |
There was a problem hiding this comment.
this is what we're going to add to for the trait-based approach?
There was a problem hiding this comment.
this is what we're going to add to for the trait-based approach?
Yeah.
dropshot_endpoint/src/endpoint.rs
Outdated
| @@ -834,6 +1044,57 @@ mod tests { | |||
| ); | |||
| } | |||
|
|
|||
| // These argument types are close to being invalid, but are actually valid. | |||
There was a problem hiding this comment.
Is it that these are odd but valid types? or could you elaborate on this proximity to invalidity?
There was a problem hiding this comment.
Expanded the comment here to describe the changes which would make these types invalid.
It won't succeed at compiling, but it'll produce some pretty rough error messages: https://gist.github.com/sunshowers/c83254c5f1002b410ae05f9426c78b2d |
Created using spr 1.3.6-beta.1
Created using spr 1.3.6-beta.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are forced to do some of this validation for trait-based servers, and
catching things like non-static lifetime parameters early can make this a nicer
experience. We don't try and capture everything, just some of the things that
are either required for, or closely related to, trait-based servers.
Depends on #1009.