[2/n] [dropshot-endpoint] turn valid endpoint tests into snapshot tests #1010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created using spr 1.3.6-beta.1
Created using spr 1.3.6-beta.1 [skip ci]
Created using spr 1.3.6-beta.1
sunshowers
changed the base branch from
main
to
sunshowers/spr/main.dropshot-endpoint-turn-valid-endpoint-tests-into-snapshot-tests
sunshowers
changed the base branch from
sunshowers/spr/main.dropshot-endpoint-turn-valid-endpoint-tests-into-snapshot-tests
to
main
sunshowers
changed the title
Created using spr 1.3.6-beta.1
ahl
approved these changes
May 31, 2024
| @@ -465,82 +468,12 @@ mod tests { | |||
| }, | |||
| ) | |||
| .unwrap(); | |||
| let expected = quote! { | |||
There was a problem hiding this comment.
code that predates expectorate! how quaint!
sunshowers
deleted the
sunshowers/spr/dropshot-endpoint-turn-valid-endpoint-tests-into-snapshot-tests
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use expectorate to manage these tests. It's much easier to see the outputs, and
to make changes to them, this way.