Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug where resource with name consists of only numbers won't showup in the trash bin #10920

Merged
merged 2 commits into from
May 16, 2024

Conversation

AlexAndBear
Copy link
Contributor

@AlexAndBear AlexAndBear commented May 16, 2024

Description

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests
  • Documentation
  • Maintenance (e.g. dependency updates or tooling)

Open tasks:

  • ...

Copy link

sonarcloud bot commented May 16, 2024

Copy link
Member

@dschmidt dschmidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is the value parsed to a number in the first place?!

This seems more like fighting the symptom rather than the root cause

@AlexAndBear
Copy link
Contributor Author

AlexAndBear commented May 16, 2024

Why is the value parsed to a number in the first place?!

This seems more like fighting the symptom rather than the root cause

We do this string parsing in L79 as well, the root issue might go down to the XML builder (webdav) that seems to automatically parse the data to the most matching data type as we don't hand it a scheme.
We might look into that later but I think that would go too far to fix a p2 bug, while we already to the same kind of parsing in the code already.

@AlexAndBear AlexAndBear requested a review from dschmidt May 16, 2024 09:50
Copy link
Member

@dschmidt dschmidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clarified: I still think it's suspicious, that we get a number here - but web-client seems to be the right level to handle this and we handle it analogously for other props.

LGTM

@AlexAndBear AlexAndBear merged commit 29840de into stable-8.0 May 16, 2024
3 checks passed
@delete-merged-branch delete-merged-branch bot deleted the issues/10917 branch May 16, 2024 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants