Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests-only][full-ci] add e2e test to view real time update of content #10908

Merged

Conversation

anon-pradip
Copy link
Contributor

Description

This test ensures that: when content of a file with "Can edit" permission is opened with the public link and password shared by creator to an "anonymous" user then the changes made by "anonymous" user are seen by the creator in real-time in both Collabora and OnlyOffice environments .

Related Issue

Motivation and Context

How Has This Been Tested?

  • Locally

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests
  • Documentation
  • Maintenance (e.g. dependency updates or tooling)

Open tasks:

@anon-pradip anon-pradip marked this pull request as draft May 15, 2024 09:47
@anon-pradip anon-pradip force-pushed the test/view-real-time-update-of-content branch 4 times, most recently from 3d03c24 to 36d3df8 Compare May 16, 2024 06:18
@anon-pradip anon-pradip marked this pull request as ready for review May 16, 2024 06:58
tests/e2e/cucumber/steps/ui/resources.ts Outdated Show resolved Hide resolved
@anon-pradip anon-pradip force-pushed the test/view-real-time-update-of-content branch from 36d3df8 to 6ae63ac Compare May 16, 2024 11:19
@anon-pradip anon-pradip force-pushed the test/view-real-time-update-of-content branch from 6ae63ac to fcf0670 Compare May 17, 2024 06:52
Copy link
Contributor

@PrajwolAmatya PrajwolAmatya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@anon-pradip anon-pradip force-pushed the test/view-real-time-update-of-content branch from fcf0670 to 24e31b5 Compare May 20, 2024 08:30
Copy link
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Also port the PR to the master

@saw-jan
Copy link
Member

saw-jan commented May 20, 2024

@anon-pradip Please, rebase the PR

@anon-pradip anon-pradip force-pushed the test/view-real-time-update-of-content branch 2 times, most recently from 0d4830b to 6084d78 Compare May 21, 2024 04:50
@anon-pradip anon-pradip force-pushed the test/view-real-time-update-of-content branch from 6084d78 to d7803b4 Compare May 21, 2024 04:55
@anon-pradip anon-pradip force-pushed the test/view-real-time-update-of-content branch from d7803b4 to 52af3da Compare May 21, 2024 06:15
Copy link

sonarcloud bot commented May 21, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@saw-jan saw-jan merged commit ee52645 into owncloud:stable-8.0 May 21, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants