fix: token refresh in single binary and wopi deployment example #9167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
DeepDiver1975
force-pushed
the
fix/wopi-example-token-refresh
branch
from
9490017
to
b4f8ec1
Compare
rhafer
requested changes
May 14, 2024
There was a problem hiding this comment.
AFAIK the problem is also present in a default deployment (i.e. without wopi and any other external stuff). So I guess we need to update the default config https://github.com/owncloud/ocis/blob/master/services/proxy/pkg/config/csp.yaml as well?
Testing this ... |
|
Single binary has the same issue.... |
DeepDiver1975
force-pushed
the
fix/wopi-example-token-refresh
branch
from
b4f8ec1
to
c1eb5e6
Compare
DeepDiver1975
changed the title
rhafer
approved these changes
May 14, 2024
AlexAndBear
approved these changes
May 14, 2024
DeepDiver1975
force-pushed
the
fix/wopi-example-token-refresh
branch
from
c1eb5e6
to
0cf3298
Compare
|
rebased ..... let's see if drone likes this now ..... 🤷 |
kulmann
approved these changes
May 15, 2024
|
@DeepDiver1975 The tests are failing because they expect different CSP headers. |
DeepDiver1975
force-pushed
the
fix/wopi-example-token-refresh
branch
from
0cf3298
to
ba2ff61
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When refreshing the oidc client loads ocis in an iframe - which was disallowed until this fix.
Related Issue
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: