feat(proxy): Update selected attributes of autoprovisioned users #9166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When autoprovisioning is enabled, we now update autoprovisioned users when their display name or email address claims change. Closes: owncloud#8955
|
kobergj
approved these changes
May 15, 2024
Comment on lines
+253
to
+269
| authRes, err := gatewayClient.Authenticate(newctx, &gateway.AuthenticateRequest{ | ||
| Type: "serviceaccounts", | ||
| ClientId: c.serviceAccount.ServiceAccountID, | ||
| ClientSecret: c.serviceAccount.ServiceAccountSecret, | ||
| }) | ||
| if err != nil { | ||
| return err | ||
| } | ||
| if authRes.GetStatus().GetCode() != rpcv1beta1.Code_CODE_OK { | ||
| return fmt.Errorf("error authenticating service user: %s", authRes.GetStatus().GetMessage()) | ||
| } | ||
|
|
||
| lgClient, err := c.setupLibregraphClient(newctx, authRes.GetToken()) | ||
| if err != nil { | ||
| c.logger.Error().Err(err).Msg("Error setting up libregraph client") | ||
| return err | ||
| } |
There was a problem hiding this comment.
Do we need to extract the service account token in other places too? It might make sense to move this to the utils package then. I like how the service account authentication is hidden in some helper pkg...
Not relevant for this PR - just asking.
There was a problem hiding this comment.
Hm, good thought. I think we're using it just here currently (but here already twice). I'll check if I can rework that in another PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When autoprovisioning is enabled, we now update autoprovisioned users when their display name or email address claims change.
Closes: #8955