Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only] [full-ci] Use sharingNg in coreApiShareOperationsToShares1 #9162

Merged
merged 8 commits into from
May 15, 2024
Merged

[tests-only] [full-ci] Use sharingNg in coreApiShareOperationsToShares1 #9162

merged 8 commits into from
May 15, 2024

Conversation

Salipa-Gurung
Copy link
Contributor

@Salipa-Gurung Salipa-Gurung commented May 14, 2024 •
edited

Description

Changed Given step for sharing using SharingNg in coreApiShareOperationsToShares1:

  1. accessToShare.feature
  2. changingFilesShare.feature
  3. gettingShares.feature
  4. gettingSharesPendingFiltered.feature
  5. gettingSharesReceivedFiltered.feature
  6. gettingSharesReceivedFilteredEmpty.feature
  7. gettingSharesSharedFiltered.feature
  8. gettingSharesSharedFilteredEmpty.feature

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@Salipa-Gurung Salipa-Gurung self-assigned this May 14, 2024
@Salipa-Gurung Salipa-Gurung mentioned this pull request May 14, 2024
Closed
@Salipa-Gurung Salipa-Gurung force-pushed the use-sharingNG-in-coreApiShareOperationsToShares branch from ead970b to 580671e Compare May 15, 2024 06:25
@Salipa-Gurung Salipa-Gurung force-pushed the use-sharingNG-in-coreApiShareOperationsToShares branch from 580671e to 056595b Compare May 15, 2024 08:52
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 15, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@saw-jan saw-jan merged commit 20eda8b into master May 15, 2024
4 checks passed
@delete-merged-branch delete-merged-branch bot deleted the use-sharingNG-in-coreApiShareOperationsToShares branch May 15, 2024 09:36
ownclouders pushed a commit that referenced this pull request May 15, 2024
@Salipa-Gurung
[tests-only] [full-ci] Use sharingNg in coreApiShareOperationsToShare…
7bec029 
…s1 (#9162)

* update given step using sharingNg in accessToShare.feature

* update given step using sharingNg in changingFilesShare.feature

* update given step using sharingNg in gettingShares.feature

* update given step using sharingNg in gettingSharesPendingFiltered.feature

* update given step using sharingNg in gettingSharesReceivedFiltered.feature

* update given step using sharingNg in gettingSharesReceivedFilteredEmpty.feature

* update given step using sharingNg in gettingSharesSharedFiltered.feature

* update given step using sharingNg in gettingSharesSharedFilteredEmpty.feature
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saw-jan saw-jan saw-jan approved these changes

@grgprarup grgprarup Awaiting requested review from grgprarup

@S-Panta S-Panta Awaiting requested review from S-Panta

Assignees

@Salipa-Gurung Salipa-Gurung

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Salipa-Gurung @saw-jan