Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only][full-ci] divide shareNg test suite into multiple parts #9158

Merged
merged 5 commits into from
May 16, 2024
Merged

[tests-only][full-ci] divide shareNg test suite into multiple parts #9158

merged 5 commits into from
May 16, 2024

Conversation

PrajwolAmatya
Copy link
Contributor

@PrajwolAmatya PrajwolAmatya commented May 14, 2024 •
edited

Description

Currently, the apiSharingNg test pipeline takes more than 20-25 minutes to get completed, resulting in longer run time for CI. To resolve this, the apiSharingNg test suite is divided into 3 parts covering the following feature files, so that each test pipelines will complete within 15 minutes.

1. apiSharingNgLinkShare
    - linkShare.feature
2. apiSharingNg
    - enableDisableShareSync.feature
    - listPermissions.feature
    - propfindShares.feature
    - removeAccessToDrive.feature
    - removeAccessToDriveItem.feature
    - sharedByMe.feature
    - sharedWithMe.feature
    - sharedWithMeSyncDisabled.feature
3. apiSharingNgShareInvitations
    - shareInvitations.feature
    - updateShareInvitations.feature

With this,

  • apiSharingNgLinkShare takes around 08:51,
  • apiSharingNg takes around 08:30, and
  • apiSharingNgShareInvitations takes around 10:53 minutes.

Related Issue

@PrajwolAmatya PrajwolAmatya force-pushed the drone/divide-shareNg-suite branch 2 times, most recently from af1010f to d5c4c25 Compare May 14, 2024 10:27
@PrajwolAmatya PrajwolAmatya self-assigned this May 14, 2024
@PrajwolAmatya PrajwolAmatya changed the title [tests-only][full-ci] divide shareNg test suite into 2 parts [tests-only][full-ci] divide shareNg test suite into multiple parts May 14, 2024
@PrajwolAmatya PrajwolAmatya mentioned this pull request May 14, 2024
Closed
10 tasks
@PrajwolAmatya PrajwolAmatya force-pushed the drone/divide-shareNg-suite branch 3 times, most recently from 4f03a15 to 0c213f8 Compare May 16, 2024 03:32
@PrajwolAmatya PrajwolAmatya marked this pull request as ready for review May 16, 2024 04:17
saw-jan
saw-jan reviewed May 16, 2024
View reviewed changes
.drone.star Outdated Show resolved Hide resolved
saw-jan
saw-jan approved these changes May 16, 2024
View reviewed changes
Copy link
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@saw-jan saw-jan requested a review from ScharfViktor May 16, 2024 06:07
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 16, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@PrajwolAmatya PrajwolAmatya merged commit 52e7ae9 into master May 16, 2024
3 checks passed
@delete-merged-branch delete-merged-branch bot deleted the drone/divide-shareNg-suite branch May 16, 2024 06:51
ownclouders pushed a commit that referenced this pull request May 16, 2024
@PrajwolAmatya
[tests-only][full-ci] divide shareNg test suite into multiple parts (#…
9561a31 
…9158)

* divide shareNg test suite into 2 parts

* update directory name in expected failure file

* separate apisharingNg suite

* separate shareNg test suite to 3 parts

* remove unused context files from test suites
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saw-jan saw-jan saw-jan approved these changes

@ScharfViktor ScharfViktor ScharfViktor approved these changes

@grgprarup grgprarup Awaiting requested review from grgprarup

@SagarGi SagarGi Awaiting requested review from SagarGi

@Salipa-Gurung Salipa-Gurung Awaiting requested review from Salipa-Gurung

@amrita-shrestha amrita-shrestha Awaiting requested review from amrita-shrestha

@nabim777 nabim777 Awaiting requested review from nabim777

@S-Panta S-Panta Awaiting requested review from S-Panta

@nirajacharya2 nirajacharya2 Awaiting requested review from nirajacharya2

Assignees

@PrajwolAmatya PrajwolAmatya

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@PrajwolAmatya @saw-jan @ScharfViktor