Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix service names for userlog, graph, invitations, sse and web #9149

Merged
merged 1 commit into from
May 24, 2024

Conversation

butonic
Copy link
Member

@butonic butonic commented May 13, 2024

we did not always stick to the correct service name pattern:

  • http services should live in the com.owncloud.web namespace
  • grpc services should live in the com.owncloud.api namespace
  • we could add a com.owncloud.debug namespace for all the debug ports ... (not part of this pr)

it seems the userlog code got copy pasted into several services ...

We need to add a changelog for this and maybe add the env vars to the helmchart in case someone intends to mix versions ...

Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@butonic butonic requested a review from kulmann as a code owner May 13, 2024 15:08
Copy link

update-docs bot commented May 13, 2024

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@butonic butonic self-assigned this May 13, 2024
Copy link

sonarcloud bot commented May 13, 2024

@butonic butonic merged commit 7b47d55 into master May 24, 2024
3 checks passed
@delete-merged-branch delete-merged-branch bot deleted the correct-servicenames branch May 24, 2024 08:40
ownclouders pushed a commit that referenced this pull request May 24, 2024
fix service names for userlog, graph, invitations, sse and web
ownclouders pushed a commit that referenced this pull request May 25, 2024
fix service names for userlog, graph, invitations, sse and web
ownclouders pushed a commit that referenced this pull request May 26, 2024
fix service names for userlog, graph, invitations, sse and web
ownclouders pushed a commit that referenced this pull request May 27, 2024
fix service names for userlog, graph, invitations, sse and web
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants