Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

route /wopi to collaboration service #9148

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

butonic
Copy link
Member

@butonic butonic commented May 13, 2024

I am trying to run the collaboration service as easily as possible, but it does not work as expected when tryin to replace the approvider with it:

	"OCIS_ADD_RUN_SERVICES": "collaboration",
	"OCIS_EXCLUDE_RUN_SERVICES": "app-provider",
	"COLLABORATION_WOPIAPP_ADDR": "https://onlyoffice.ocis.test",
	"COLLABORATION_HTTP_ADDR": "https://cloud.ocis.test",
	"COLLABORATION_HTTP_SCHEME": "https",

I had to make the runtime recognize the collaboration service and start it, register proper service names and make the proxi route /wopi to the collaboration provider.

Copy link

update-docs bot commented May 13, 2024

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@micbar
Copy link
Contributor

micbar commented May 13, 2024

@butonic why now go through the proxy?

I was working under the assuption that we do not route wopi requests through the proxy.

How would you do that with 3 collaboration services?

@micbar
Copy link
Contributor

micbar commented May 13, 2024

I think "COLLABORATION_HTTP_ADDR": "wopiserver-collabora.ocis.test", should be the config.

@butonic
Copy link
Member Author

butonic commented May 14, 2024

We already learned that multiple collaboration services are only confusing end users. So IMO the default ocis setup should host one default /wopi endpoint. If you really really need additional wopi servers, only then will you need to set up a new (sub-)domain for it.

I think we sshould even default to "COLLABORATION_HTTP_ADDR": "https://localhost:9200", or well, OCIS_URL

@butonic butonic force-pushed the collaboration-service-names branch from 388cc48 to 5f3c6cb Compare May 14, 2024 10:55
@butonic
Copy link
Member Author

butonic commented May 14, 2024

hm ... I now see that the collaboration service uses the http addr differently than all other services ...
and it does not register the the grpc service in go micro (intentionally) ... I need to double check that works because the registry is still used to look up the service afaict ...

@butonic butonic mentioned this pull request May 15, 2024
9 tasks
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@butonic butonic force-pushed the collaboration-service-names branch 3 times, most recently from 4e006bf to 9f611f7 Compare May 23, 2024 14:34
@butonic
Copy link
Member Author

butonic commented May 23, 2024

meh, the approvider part dies if it cannot connect to the wopi client to discover the urls ... urgh ... so we cannot start it by default ...

@butonic butonic force-pushed the collaboration-service-names branch from 9f611f7 to 003c422 Compare May 23, 2024 15:23
…ication

Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@butonic butonic force-pushed the collaboration-service-names branch from 003c422 to 9338091 Compare May 23, 2024 15:35
Copy link

sonarcloud bot commented May 23, 2024

@butonic butonic marked this pull request as draft May 24, 2024 08:49
@butonic
Copy link
Member Author

butonic commented May 24, 2024

I'll first work on #9165 and then rebase this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants