-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
route /wopi to collaboration service #9148
base: master
Are you sure you want to change the base?
Conversation
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
@butonic why now go through the proxy? I was working under the assuption that we do not route wopi requests through the proxy. How would you do that with 3 collaboration services? |
I think |
We already learned that multiple collaboration services are only confusing end users. So IMO the default ocis setup should host one default I think we sshould even default to |
388cc48
to
5f3c6cb
Compare
hm ... I now see that the collaboration service uses the http addr differently than all other services ... |
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
4e006bf
to
9f611f7
Compare
meh, the approvider part dies if it cannot connect to the wopi client to discover the urls ... urgh ... so we cannot start it by default ... |
9f611f7
to
003c422
Compare
…ication Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
003c422
to
9338091
Compare
Quality Gate passedIssues Measures |
I'll first work on #9165 and then rebase this PR |
I am trying to run the collaboration service as easily as possible, but it does not work as expected when tryin to replace the approvider with it:
I had to make the runtime recognize the
collaboration
service and start it, register proper service names and make the proxi route/wopi
to the collaboration provider.