Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the watermark text for the Secure View mode #9144

Merged
merged 1 commit into from
May 15, 2024

Conversation

2403905
Copy link
Contributor

@2403905 2403905 commented May 13, 2024

Description

We've added the watermark text for the Secure View mode.

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@jvillafanez
Copy link
Member

I think we should add some unit tests to cover the code. It should be easy just by copying any existing test and adjusting it.

@2403905 2403905 force-pushed the issue-9067 branch 4 times, most recently from 3f8dfd9 to 218ae02 Compare May 14, 2024 21:33
Copy link

sonarcloud bot commented May 14, 2024

@2403905 2403905 merged commit 39f63d3 into owncloud:master May 15, 2024
3 checks passed
ownclouders pushed a commit that referenced this pull request May 15, 2024
Added the watermark text for the Secure View mode
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants