Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[full-ci] [tests-only] Use sharing ng in given steps api spaces shares suite #9143

Merged
merged 3 commits into from
May 15, 2024
Merged

[full-ci] [tests-only] Use sharing ng in given steps api spaces shares suite #9143

merged 3 commits into from
May 15, 2024

Conversation

grgprarup
Copy link
Contributor

Description

Used sharingNG graph API in the given steps for sharing.

Suites covered:

  • apiSpacesShares/
    • shareSubItemOfSpaceViaPublicLink.feature
    • shareUploadTUS.feature

Related Issue

How Has This Been Tested?

  • Locally
  • 🤖

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@grgprarup grgprarup self-assigned this May 13, 2024
@grgprarup grgprarup marked this pull request as draft May 13, 2024 11:41
@grgprarup grgprarup mentioned this pull request May 13, 2024
Closed
@grgprarup grgprarup force-pushed the use-sharingNG-in-given-steps-apiSpacesShares-suite-2 branch from ccff6c6 to 46b85d6 Compare May 14, 2024 04:25
@grgprarup grgprarup force-pushed the use-sharingNG-in-given-steps-apiSpacesShares-suite-2 branch from 46b85d6 to 286de1a Compare May 15, 2024 06:10
@grgprarup grgprarup marked this pull request as ready for review May 15, 2024 06:10
@grgprarup grgprarup force-pushed the use-sharingNG-in-given-steps-apiSpacesShares-suite-2 branch from 286de1a to f30ad2f Compare May 15, 2024 06:50
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 15, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@grgprarup grgprarup merged commit 3949dd5 into master May 15, 2024
4 checks passed
ownclouders pushed a commit that referenced this pull request May 15, 2024
@grgprarup
Merge pull request #9143 from owncloud/use-sharingNG-in-given-steps-a…
d694c21 
…piSpacesShares-suite-2

[full-ci] [tests-only] Use sharing ng in given steps api spaces shares suite
@grgprarup grgprarup deleted the use-sharingNG-in-given-steps-apiSpacesShares-suite-2 branch May 15, 2024 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saw-jan saw-jan saw-jan approved these changes

@SagarGi SagarGi Awaiting requested review from SagarGi

@Salipa-Gurung Salipa-Gurung Awaiting requested review from Salipa-Gurung

@amrita-shrestha amrita-shrestha Awaiting requested review from amrita-shrestha

@S-Panta S-Panta Awaiting requested review from S-Panta

@PrajwolAmatya PrajwolAmatya Awaiting requested review from PrajwolAmatya

@nirajacharya2 nirajacharya2 Awaiting requested review from nirajacharya2

Assignees

@grgprarup grgprarup

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@grgprarup @saw-jan