Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests-only][full-ci]changing given from ocs to graph in feature file #9142

Conversation

S-Panta
Copy link
Contributor

@S-Panta S-Panta commented May 13, 2024

Description

updating given statement of test suite to use graph API
Suites covered:

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment:
  • locally
  • ci

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Copy link

update-docs bot commented May 13, 2024

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@S-Panta S-Panta self-assigned this May 14, 2024
@S-Panta S-Panta force-pushed the refactor-given-step-of-coreapiShareManagementToBasic-to-use-graph-for-share branch from 6a7a213 to e93ae8c Compare May 14, 2024 10:41
@S-Panta S-Panta changed the title [WIP][do-not-merge]changing given from ocs to graph in feature file [tests-only][full-ci]changing given from ocs to graph in feature file May 14, 2024
@S-Panta S-Panta marked this pull request as ready for review May 14, 2024 10:45
@S-Panta S-Panta force-pushed the refactor-given-step-of-coreapiShareManagementToBasic-to-use-graph-for-share branch 2 times, most recently from f6877c7 to cc0e086 Compare May 14, 2024 11:26
@S-Panta S-Panta requested review from grgprarup and saw-jan May 15, 2024 04:22
@S-Panta S-Panta force-pushed the refactor-given-step-of-coreapiShareManagementToBasic-to-use-graph-for-share branch from cc0e086 to 427be18 Compare May 15, 2024 04:24
@S-Panta S-Panta force-pushed the refactor-given-step-of-coreapiShareManagementToBasic-to-use-graph-for-share branch from 427be18 to 03d9a5f Compare May 16, 2024 03:45
Copy link

sonarcloud bot commented May 16, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@S-Panta S-Panta merged commit 6284411 into master May 16, 2024
3 checks passed
@delete-merged-branch delete-merged-branch bot deleted the refactor-given-step-of-coreapiShareManagementToBasic-to-use-graph-for-share branch May 16, 2024 09:49
ownclouders pushed a commit that referenced this pull request May 16, 2024
…#9142)

* changing given from ocs to graph in feature file

* addressing reviews
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants