Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests-only][full-ci]adding tests for enable disable sync when sharer is deleted #9130

Merged
merged 2 commits into from
May 15, 2024

Conversation

S-Panta
Copy link
Contributor

@S-Panta S-Panta commented May 10, 2024

Description

Adding scenario related to enable disable sync of share when sharer is deleted.
;
Previously $this->rememberThatGroupIsNotExpectedToExist($group) step was added here #8886 but mistakenly deleted in this PR #8892.
Group deletion will fail in AfterScenerio. if this isn't used.

Related Issue

How Has This Been Tested?

  • test environment:
  • locally
  • ci

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Copy link
Contributor

@amrita-shrestha amrita-shrestha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

request to change the scenario title. and the remaining ones

@S-Panta S-Panta force-pushed the enable-disable-share-sync-when-sharer-is-deleted branch 2 times, most recently from 3dac4be to 56356db Compare May 14, 2024 11:28
@S-Panta S-Panta force-pushed the enable-disable-share-sync-when-sharer-is-deleted branch from 56356db to e54da51 Compare May 15, 2024 06:31
Copy link

sonarcloud bot commented May 15, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@S-Panta S-Panta merged commit 95c93f6 into master May 15, 2024
4 checks passed
@delete-merged-branch delete-merged-branch bot deleted the enable-disable-share-sync-when-sharer-is-deleted branch May 15, 2024 07:13
ownclouders pushed a commit that referenced this pull request May 15, 2024
… is deleted (#9130)

* adding tests for enable disable sync when sharer is deleted

* addhressing reviews
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants