Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ocis][Secure View] Open files in Collabora with watermark #9067

Closed
16 tasks
micbar opened this issue May 3, 2024 · 8 comments
Closed
16 tasks

[ocis][Secure View] Open files in Collabora with watermark #9067

micbar opened this issue May 3, 2024 · 8 comments
Assignees
Labels
Type:Story User Story

Comments

@micbar
Copy link
Contributor

micbar commented May 3, 2024

Description

Open File in Collabora with watermark and exports (print, download) disabled

User Stories

  • As a user, i want to share files which cannot be downloaded to keep confidential content secure

Value

Make ocis usable for higly confident data

Acceptance Criteria

  • Collabora can open the possible file types in watermark mode
  • with download disabled
  • with printing disabled

Research results

From #8855

We can modify the response of the "CheckFileInfo" WOPI call to control the viewing mode of Collabora.

Definition of ready

  • Everybody needs to understand the value written in the user story
  • Acceptance criteria have to be defined
  • All dependencies of the user story need to be identified
  • Feature should be seen from an end user perspective
  • Story has to be estimated
  • Story points need to be less than 20

Definition of done

  • Functional requirements
    • Functionality described in the user story works
    • Acceptance criteria are fulfilled
  • Quality
    • Code review happened
    • CI is green (that includes new and existing automated tests)
    • Critical code received unit tests by the developer
  • Non-functional requirements
    • No sonar cloud issues
  • Configuration changes
    • The next branch of the ocis charts is compatible
@micbar micbar added the Type:Story User Story label May 3, 2024
@micbar micbar changed the title [ocis] [Secure View] [ocis][Secure View] May 3, 2024
@micbar micbar changed the title [ocis][Secure View] [ocis][Secure View] Open File in Collabora with watermark May 3, 2024
@micbar micbar changed the title [ocis][Secure View] Open File in Collabora with watermark [ocis][Secure View] Open files in Collabora with watermark May 3, 2024
@2403905 2403905 self-assigned this May 7, 2024
@2403905
Copy link
Contributor

2403905 commented May 9, 2024

@micbar Should we add the new env variable for the watermark or just use some default text?

@micbar
Copy link
Contributor Author

micbar commented May 10, 2024

Username and email if you ask me, no config var.

@tbsbdr

@tbsbdr
Copy link
Contributor

tbsbdr commented May 13, 2024

👍 yes, Username and email, no config var

@ScharfViktor
Copy link
Contributor

👍 yes, Username and email, no config var

should we consider here OCIS_SHOW_USER_EMAIL_IN_RESULTS=false/true?
I would suggest -> no email if OCIS_SHOW_USER_EMAIL_IN_RESULTS=false

@micbar
Copy link
Contributor Author

micbar commented May 13, 2024

IMHO different use case.

In this case the email is only shown to the user which belongs to it. It should prevent making a screenshot because that would be connected to the user and email.

@2403905
Copy link
Contributor

2403905 commented May 13, 2024

IMHO different use case.

In this case the email is only shown to the user which belongs to it. It should prevent making a screenshot because that would be connected to the user and email.

Do you mean if Albert Einstein opened a doc it should be Albert Einstein einstein@example.org watermark ?

@micbar
Copy link
Contributor Author

micbar commented May 13, 2024

Yes. The viewer should be in the watermark.

@2403905 2403905 closed this as completed May 15, 2024
@2403905
Copy link
Contributor

2403905 commented May 15, 2024

Already merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type:Story User Story
Projects
Status: Done
Development

No branches or pull requests

4 participants