Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: lint the gherkin feature files #41251

Merged
merged 1 commit into from
May 17, 2024
Merged

tests: lint the gherkin feature files #41251

merged 1 commit into from
May 17, 2024

Conversation

phil-davis
Copy link
Contributor

@phil-davis phil-davis commented May 13, 2024 •
edited

Description

Apply most of the changes suggested by https://github.com/gherlint/gherlint/releases/tag/v1.0.0 to the acceptance test feature files.

Note: most of the lines of diff are because the expected JSON responses in the capabilities tests needed to be indented. So don't be too scared about the large number of lines of diff!

I raised issues for:
gherlint/gherlint#109
gherlint/gherlint#110
and did not apply changes related to those.

How Has This Been Tested?

CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@owncloud owncloud deleted a comment from update-docs bot May 13, 2024
@phil-davis phil-davis marked this pull request as ready for review May 13, 2024 08:33
This was referenced May 13, 2024
Closed
Closed
@phil-davis
Copy link
Contributor Author

Needs PR #41253 which fixes issue #41252 which is currently causing CI to fail.

@phil-davis
Copy link
Contributor Author

Needs PR #41253 which fixes issue #41252 which is currently causing CI to fail.

That has been merged. I rebased this PR, hopefully CI passes.

@phil-davis
Copy link
Contributor Author

@saw-jan @Salipa-Gurung this is ready for review.

saw-jan
saw-jan approved these changes May 17, 2024
View reviewed changes
Copy link
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@phil-davis phil-davis merged commit 12bd217 into master May 17, 2024
2 checks passed
@delete-merged-branch delete-merged-branch bot deleted the lint-gherkin-scenarios branch May 17, 2024 06:31
@grgprarup grgprarup mentioned this pull request May 24, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saw-jan saw-jan saw-jan approved these changes

@Salipa-Gurung Salipa-Gurung Awaiting requested review from Salipa-Gurung

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@phil-davis @saw-jan