Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor phpunit tests #36501

Merged
merged 8 commits into from Dec 7, 2019
Merged

Refactor phpunit tests #36501

merged 8 commits into from Dec 7, 2019

Commits on Dec 7, 2019

  1. Declare testCase methods void to match modern phpunit declaration

    @phil-davis
    phil-davis committed Dec 7, 2019
    Configuration menu
    Copy the full SHA
    353c641 View commit details
    Browse the repository at this point in the history

  2. Adjust phpunit expectException

    @phil-davis
    phil-davis committed Dec 7, 2019
    Configuration menu
    Copy the full SHA
    ae3aadf View commit details
    Browse the repository at this point in the history

  3. Adjust phpunit assertInternalType

    @phil-davis
    phil-davis committed Dec 7, 2019
    Configuration menu
    Copy the full SHA
    3cbffd0 View commit details
    Browse the repository at this point in the history

  4. Adjust assertContains assertNotContains for strings

    @phil-davis
    phil-davis committed Dec 7, 2019
    Configuration menu
    Copy the full SHA
    fc052d4 View commit details
    Browse the repository at this point in the history

  5. Adjust assertEqualsCanonicalizing

    @phil-davis
    phil-davis committed Dec 7, 2019
    Configuration menu
    Copy the full SHA
    5827542 View commit details
    Browse the repository at this point in the history

  6. Remove deprecated assertArraySubset

    @phil-davis
    phil-davis committed Dec 7, 2019
    Configuration menu
    Copy the full SHA
    701bfe1 View commit details
    Browse the repository at this point in the history

  7. Fix try catch in tests/lib/Lock/LockingProvider.php

    @phil-davis
    phil-davis committed Dec 7, 2019
    Configuration menu
    Copy the full SHA
    4dea2a4 View commit details
    Browse the repository at this point in the history

  8. Fixup StoragesServiceTest expectException

    @phil-davis
    phil-davis committed Dec 7, 2019
    Configuration menu
    Copy the full SHA
    7ee6f4e View commit details
    Browse the repository at this point in the history