[stable10] Use sabre/vobject ^4.2 to fix issues in ITip messages

[DeepDiver1975]

Description

Generated ITip messages are missing the timezone information.
This results in invalid ics messages which can cause issues with clients receiving these messages - e.g. MS Exchange

Related Issue

• refs … Broker: add timezone to CANCEL messages sabre-io/vobject#412

How Has This Been Tested?

• generate event in calendar app
• add attendee's email address
• receive the invite
• validate the ics attachment is valid - https://icalendar.org/validator.html
• edit the event & save
• receive update email
• validate the ics attachment is valid - https://icalendar.org/validator.html
• delete the event
• receive cancel email
• validate the ics attachment is valid - https://icalendar.org/validator.html

Screenshots (if appropriate):

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Database schema changes (next release will require increase of minor version instead of patch)
• Breaking change (fix or feature that would cause existing functionality to change)
• Technical debt
• Tests only (no source changes)

Checklist:

• Code changes
• Unit tests added
• Acceptance tests added
• Documentation ticket raised:

Open tasks:

• Backport (if applicable set "backport-request" label and remove when the backport was done)

[DeepDiver1975]

Master does not need this change - sabre/dav already pulls in the correct version

[PVince81]

do we really want to depend on alpha libraries ?

[DeepDiver1975]

do we really want to depend on alpha libraries

good point - will do a final release ...... THX for pointing out

[DeepDiver1975]

good point - will do a final release ...... THX for pointing out

sabre-io/vobject#446

[codecov]

Codecov Report

Merging #34553 into stable10 will decrease coverage by 18.59%.
The diff coverage is n/a.

@@              Coverage Diff               @@
##             stable10   #34553      +/-   ##
==============================================
- Coverage       63.68%   45.08%   -18.6%     
==============================================
  Files            1269      116    -1153     
  Lines           75553    11474   -64079     
  Branches         1293     1293              
==============================================
- Hits            48114     5173   -42941     
+ Misses          27058     5920   -21138     
  Partials          381      381

Flag	Coverage Δ	Complexity Δ
#javascript	53.29% <ø> (ø)	0 <ø> (ø)	⬇️
#phpunit	30.64% <ø> (-34.15%)	0 <ø> (-19146)

Impacted Files	Coverage Δ	Complexity Δ
lib/private/Files/Storage/DAV.php	59.45% <0%> (-21.64%)	0% <0%> (ø)
apps/updatenotification/templates/admin.php
lib/private/Encryption/Keys/Storage.php
lib/private/App/CodeChecker/NodeVisitor.php
lib/private/RedisFactory.php
apps/dav/lib/Avatars/AvatarNode.php
...s/dav/appinfo/Migrations/Version20170202213905.php
apps/dav/lib/Upload/ChunkLocationProvider.php
apps/files/lib/AppInfo/Application.php
apps/systemtags/list.php
... and 1145 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bef80b2...5d36763. Read the comment docs.

[codecov]

Codecov Report

Merging #34553 into stable10 will decrease coverage by <.01%.
The diff coverage is n/a.

@@              Coverage Diff               @@
##             stable10   #34553      +/-   ##
==============================================
- Coverage       63.93%   63.92%   -0.01%     
- Complexity      19146    19150       +4     
==============================================
  Files            1269     1269              
  Lines           75553    75560       +7     
  Branches         1293     1293              
==============================================
+ Hits            48302    48305       +3     
- Misses          26870    26874       +4     
  Partials          381      381

Flag	Coverage Δ	Complexity Δ
#javascript	53.29% <ø> (ø)	0 <ø> (ø)	⬇️
#phpunit	65.06% <ø> (-0.01%)	19150 <ø> (+4)

Impacted Files	Coverage Δ	Complexity Δ
...pps/dav/lib/SystemTag/SystemTagsByIdCollection.php	81.03% <0%> (-5.25%)	25% <0%> (+4%)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d37851...d9c22a7. Read the comment docs.

[phil-davis]

See PR #34564 for implementing the official sabre/vobject 4.2.0 in master. Something like that will need to be added to this PR.

[DeepDiver1975]

Already incorporated

[PVince81]

👍

[PVince81]

@DeepDiver1975 port to master ?

[DeepDiver1975]

Phil already Took Care of master. Pr is linked