Update libs and pin version to 5.6

[PVince81]

Update dependencies to latest version compatible with PHP 5.6.32.

Pinned version to PHP 5.6.32 because if you update the libs with composer of PHP 7 it might pick the wrong versions... So better be safe.

This PR is to be backported to stable10.
At some point we can redo the same and pin to PHP 7.1 for 10.1 on master.

Things to retest:

• Dropbox external storage app (flysystem is pulling a Dropbox v2 adapter)
• CI

[PVince81]

Hmm, we should also update the libs in "apps/files_external"... but for that I'd rather we first move out the backends and update the libs then: #27542

[PVince81]

• update the JS libs as well

[DeepDiver1975]

• dav tests need to adjust the version

OCA\DAV\Tests\unit\CardDAV\ConverterTest::testCreation with data set #0 ('BEGIN:VCARD\nVERSION:3.0\nPRODI...VCARD\n')
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
 'BEGIN:VCARD
 VERSION:3.0
-PRODID:-//Sabre//Sabre VObject 4.1.2//EN
+PRODID:-//Sabre//Sabre VObject 4.1.3//EN
 UID:12345
 FN:12345
 N:12345;;;;
 PHOTO;ENCODING=b;TYPE=JPEG:MTIzNDU2Nzg5
 END:VCARD
 '

[phil-davis]

I discovered the Sabre VObject version bump last week when rebasing the Guzzle version PR:
https://github.com/owncloud/core/pull/29773/commits

It will be good to have that merged into master so I can remove the commit from Guzzle changes.

[PVince81]

Updated JS libs to latest minor versions.

To retest:

• TEST: md5 / base64: public page upload with password
• TEST: clipboard: copy public link
• TEST: davclient, es6-promise: Webdav works
• TEST: moment: relative timestamps still work in web UI
• TEST: backbone JS: comments still work
• TEST: strengthify: password meter in personal settings
• TEST: jcrop: avatar setting
• TEST: snap: left sidebar toggle on mobile
• TEST: bowser: IE < 11 or older browsers warning
• TEST: timezone detect (?)

Note: we should consider major release update for 10.1. Note that jquery update will break a lot of things so need to plan some time...

[codecov]

Codecov Report

Merging #29822 into master will increase coverage by 0.08%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master   #29822      +/-   ##
============================================
+ Coverage     60.51%   60.59%   +0.08%     
- Complexity    18374    18487     +113     
============================================
  Files          1090     1091       +1     
  Lines         60933    61232     +299     
============================================
+ Hits          36874    37105     +231     
- Misses        24059    24127      +68

Impacted Files	Coverage Δ	Complexity Δ
lib/private/Console/Application.php	0% <0%> (ø)	23% <0%> (+7%)	⬆️
lib/private/Files/Storage/Wrapper/Checksum.php	100% <0%> (ø)	23% <0%> (+1%)	⬆️
...aring/appinfo/Migrations/Version20171215103657.php	0% <0%> (ø)	2% <0%> (?)
lib/private/User/Manager.php	76.02% <0%> (+0.26%)	60% <0%> (+1%)	⬆️
lib/private/legacy/template.php	44.65% <0%> (+0.7%)	39% <0%> (+1%)	⬆️
lib/private/Template/Base.php	73.58% <0%> (+2.47%)	17% <0%> (+4%)	⬆️
lib/private/legacy/app.php	62.53% <0%> (+3.04%)	279% <0%> (+82%)	⬆️
lib/public/Util.php	57.06% <0%> (+4.33%)	77% <0%> (+9%)	⬆️
apps/files_sharing/lib/Scanner.php	90% <0%> (+5%)	7% <0%> (ø)	⬇️
lib/private/legacy/response.php	19.51% <0%> (+10.56%)	48% <0%> (ø)	⬇️
... and 1 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a290006...47a7c11. Read the comment docs.

[PVince81]

We should also look at have the new Sabre changes released so we can update to it for #28341

[PVince81]

• update node libs (ex: karma, jasmine, etc)

[PVince81]

No output for npm update or npm outdated, so it seems our npm libs are already up to date.

[PVince81]

Regarding timezone, I didn't find what code uses it, maybe it's obsolete.

Anyway, I checked the hidden input fields and their value was set correctly, so the library update worked.

[PVince81]

👍 for @DeepDiver1975's test fixes.

Review for the update in general ?

I think we should backport this afterwards.

[PVince81]

@DeepDiver1975 can you take care of the backport and version updates in general ? seems the libs updated again...

[phil-davis]

@PVince81 @DeepDiver1975 I see a backport request label here, but it did not get backported.
So is it planned to get all the composer stuff up-to-date in stable10 for the next point release?

[PVince81]

That would be nice, yes

[phil-davis]

PR #30430 has what would be the backported code for bower.json and core/js/core.json
See comment there deciding not to push those version bumps back to stable10
#30430 (comment)

[phil-davis]

All needed backports are done.

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.