Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fixers for refactorings due to phpunit 7/8 deprecations #19

Closed
wants to merge 1 commit into from
Closed

Add fixers for refactorings due to phpunit 7/8 deprecations #19

wants to merge 1 commit into from

Conversation

phil-davis
Copy link
Contributor

See owncloud/core#36501 for description of the phpunit deprecations and associated php-cs-fixer fixes.

Add these to the regular code-style checks so that people who add new unit tests will realise to use the newer phpunit functions/methods...

In composer.json require friendsofphp/php-cs-fixer 2.16 or later, just to make sure that all the fixers will be available.

@phil-davis
Copy link
Contributor Author

Note: before actually releasing this we need to have merged owncloud/core#36501 so as not to immediately break core code-style CI.
And also release at a time when we are happy that we have either:

  • applied these fixers already in all the apps or;
  • we are happy to find out in the nightly CI which apps now fail the checks and to fix them

Or we can make this a major version release, in which case core and each app can be bumped to require owncloud/coding-standard ^2.0 as we want/are able to apply the fixers.

@phil-davis
Copy link
Contributor Author

@micbar @PVince81 @DeepDiver1975 or whoever manages this these days.
Note: I do not have any write access to this repo. I cannot add labels, or call in reviewers...

@micbar
Copy link

micbar commented Dec 2, 2019

@phil-davis Try now :-)

@phil-davis
Copy link
Contributor Author

I have access now - thanks.

@phil-davis
Copy link
Contributor Author

Or we can make this a major version release

I am now inclined to make this a major version release, so that we can implement it in each app repo in a controlled way whenever we like.

Review please.

@phil-davis
Copy link
Contributor Author

Closing in favour of #20

@phil-davis phil-davis closed this Dec 9, 2019
@phil-davis phil-davis deleted the add-phpunit-fixers branch December 9, 2019 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants