docs: Add notes/disclaimers for upgrading the copy of node-gyp that npm uses #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also mention that this is tested on npm 8, now that npm 8 exists. (Npm 8 is the same as npm 7 for purposes of these instructions.)
4 tasks
|
@DeeDeeG since nodejs#2574 is merged, i can accept these changes and make PR to main repo for you |
Also mention that this is tested on npm 8, now that npm 8 exists. (Npm 8 is the same as npm 7 for purposes of these instructions.)
owl-from-hogvarts
force-pushed
the
docs/clarify
branch
from
27413a0
to
1ed347f
Compare
owl-from-hogvarts
force-pushed
the
docs/clarify
branch
from
1ed347f
to
b6ccf92
Compare
|
Ops! I am not so familiar on how github PR merge works, so it seems that i mess up something. Can you rebase your changes onto |
|
Hi @owl-from-hogvarts, I will make my own PR at upstream. (nodejs#2585). There should not be merge conflicts since we are modifying different parts of the files. Just be sure to base your branch off upstream Thanks for working on this, by the way! Good docs are super important IMO. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description of change
For nodejs#2574. (If merged, these changes would become part of that PR, over at the upstream repo.)
This contribution is to add some notes/warnings/disclaimers about which versions of npm these pages of documentation will work with. And a little warning that one of the methods is wiped out if you reinstall or upgrade npm or node.
My attempt to address this review comment: nodejs#2574 (review) (from the original PR you posted at the upstream repo).
(Thanks for working on this! I don't want npm 7 and 8 users left confused or without a working solution. And good docs are super important to me, personally.)