fix: decode bytes not str

proper fix for nodejs#118 Special thanks to @cclauss
owl-from-hogvarts · Jul 31, 2022 · e0c0ad4 · e0c0ad4
1 parent 1f421c9
commit e0c0ad4
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/pylib/gyp/easy_xml.py b/pylib/gyp/easy_xml.py
@@ -123,7 +123,10 @@ def WriteXmlIfChanged(content, path, encoding="utf-8", pretty=False,
 
     default_encoding = locale.getdefaultlocale()[1]
     if default_encoding and default_encoding.upper() != encoding.upper():
-        xml_string = xml_string.encode(encoding)
+        if sys.platform == "win32":
+            if isinstance(xml_string, str):
+                xml_string = xml_string.decode("cp1251")  # str --> bytes
+            xml_string = xml_string.encode(encoding)  # bytes --> str
 
     # Get the old content
     try: