New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Webpack 5 馃弾 #621
Closed
Closed
Webpack 5 馃弾 #621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sokra
suggested changes
Sep 9, 2020
marcelgerber
force-pushed
the
webpack-5
branch
2 times, most recently
from
September 14, 2020 17:52
d628c24
to
ab120b7
Compare
marcelgerber
force-pushed
the
webpack-5
branch
3 times, most recently
from
September 22, 2020 23:21
3833903
to
2add44a
Compare
marcelgerber
force-pushed
the
webpack-5
branch
from
September 26, 2020 19:58
2add44a
to
e476212
Compare
webpack no longer polyfills `process`, so we need to handle that
`filenamify` requires `path`, which is no longer polyfilled in webpack 5
Co-authored-by: Tobias Koppers <tobias.koppers@googlemail.com>
This reverts commit 2e1930c.
marcelgerber
force-pushed
the
webpack-5
branch
from
October 7, 2020 08:49
0bedf01
to
89ad08e
Compare
Let's close this now since it's gone very stale - we can revisit this at some point in the future (and of course use this PR for reference), or maybe we want to switch away from Webpack after all at some point. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Webpack 5 it is, since it speeds up builds quite a lot.
A warm (with cache) Webpack development build with small changes now takes a mere 7 seconds, and a production build is down to 24s 馃殌
There are still a few things to do or wait for:
webpack-cli
4.0webpack serve
fails withTypeError: cli.commandLineArgs is not a function
聽webpack/webpack-cli#1814yarn webpack serve
cache files are written to disk, but not foryarn webpack
? (Project withwebpack-cli@4.0.0-rc.0
doesn't use cache聽webpack/webpack-cli#1842)dotenv-webpack
Webpack 5 support (feat: supporting webpack 5聽mrsteele/dotenv-webpack#234)settings.ts
after upgradingdotenv-webpack
filenamify
, since it requirespath
filenamify
with webpack 5, without adding apath
polyfill聽sindresorhus/filenamify#16csv-parse
, since it requiresBuffer
webpackVersion
check doesn't work if multiple versions of webpack are in use聽webpack-contrib/mini-css-extract-plugin#600 to be fixedwebpack-manifest-plugin
The changes
csv-parse
->papaparse
andfilenamify
->sanitize-filename
are needed because Webpack 5 removes automatic Node polyfills.We could still manually polyfill those, but I thought it to be cleaner to use browser-first modules instead.