Dont publish migration if migration exists #692
Conversation
|
Hi @MortenDHansen , Laravel 8.37 was released with anonymous migration support, then maybe we can check if the file exists instead of the class. |
| sprintf('migrations/%s_create_audits_table.php', date('Y_m_d_His')) | ||
| ), | ||
| ], 'migrations'); | ||
| if (!class_exists('CreateAuditsTable')) { |
There was a problem hiding this comment.
check if the file exists instead of the class.
|
Yeah, but i don't think you actually need to use the anonymous migrations if you don't want to. If we expect all existing migrations to be created as a class and we dont change how we publish it, then the class check should be enough. Spatie seems use same approach: https://github.com/spatie/laravel-translation-loader/blob/main/src/TranslationServiceProvider.php |
|
Looks good to me! thanks |
|
@MortenDHansen the change is not working for me, at least not working for Laravel Framework 9.9.0, I still can keep on publishing migration files. Maybe we should change the way to check if file exists instead of the class. |
|
Yeah, maybe my brilliant simple fix was not as brilliant as i figured, and a bit too simple :/ |
As suggested with pr #644