Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow interfaces implement interfaces #813

Merged

Conversation

murtukov
Copy link
Member

Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Documented? no
Fixed tickets graphql/graphql-spec#373

According to the GraphQL Specification update, interfaces can implement other interfaces. The webonyx/graphql-php already implemented it in 14.5.0 (webonyx/graphql-php#740). This PR makes corresponding changes.

Copy link
Member

@mcg-web mcg-web left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

webonyx/graphql-php lib version should be change to >=14.5 in the bundle deps.

@murtukov murtukov requested a review from mcg-web January 25, 2021 16:05
Copy link
Member

@mcg-web mcg-web left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @murtukov !

@murtukov murtukov merged commit a3feed7 into overblog:master Jan 25, 2021
@murtukov murtukov deleted the feature/interfaces-implementing-interfaces branch January 25, 2021 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants