bump packer sdk version to address legacy SSH key algorithms in SSH communicator #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ommunicator Signed-off-by: Ubuntu <outscale@ip-10-9-21-61.eu-west-2.compute.internal>
jerome-jutteau
approved these changes
Sep 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue is when connecting with Packer to the instance with SSH, we face removal of ssh-rsa from PubKeyAcceptedTypes:
RSA-2048 keys do still work in general, as long as your SSH client is using sha256 signatures
The issue is that the Go library used by Packer (and others) does not.
OpenSSH migrated the ssh-rsa key type, which historically used the ssh-rsa signature algorithm based on SHA-1, to the new rsa-sha2-256 and rsa-sha2-512 signature algorithms. (Golang issues: golang/go#49952)
Packer SDK PR : hashicorp/packer-plugin-sdk#107
So we need to bump packer sdk version to use this fix