Bump Mermaid Version 9.3.0 -> 10.9.0 #6869
Open
+13
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement Fixes for Breaking Changes in Mermaid >10.0.0
|
|
|
Not gonna lie this is way above my league ill take a look at the bundle size but if i cant figure it out ill probably end up just building my own image with this fix for now. |
twliqiang
reviewed
May 13, 2024
| @@ -66,7 +66,7 @@ class MermaidRenderer { | |||
| const cacheKey = `${isDark ? "dark" : "light"}-${text}`; | |||
| const cache = Cache.get(cacheKey); | |||
| if (cache) { | |||
| element.classList.remove("parse-error", "empty"); | |||
| elemƒent.classList.remove("parse-error", "empty"); | |||
There was a problem hiding this comment.
change the variable name by mistake ?
|
I would go as far as to say that outline should remove mermaid support if migrating to 10.x is not going to happen. I've given up with mermaid - everything I do is now in diagrams.net / drawio. |
|
That really makes no sense, it's not like we're running a years old version – the version of Mermaid in Outline supports all but the latest couple of graph types and is widely used by customers. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey,
so i bumped the Mermaid Version from 9.3.0 to 10.9.0 to be able to use the new Chart Types.
There have been Breaking Changes in 10.0.0 which i implemented the suggested fix for
(see https://github.com/mermaid-js/mermaid/blob/master/CHANGELOG.md#1000 )
also removed "@types/mermaid since its deprecated and mermaid provides them anyways
I have tested my fix and the only issue i found is that the xychart-beta seems to get cropped a bit. All other charts/diagrams work fine tho