Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: set project.originalModel after flattening #45

Merged
merged 1 commit into from Jan 23, 2023
Merged

feat: set project.originalModel after flattening #45

merged 1 commit into from Jan 23, 2023

Conversation

piotrwielgolaski-tomtom
Copy link
Contributor

@piotrwielgolaski-tomtom piotrwielgolaski-tomtom commented Jan 3, 2023 •
edited

it is required for shade plugin

Closes #42

📑 Description

set project.originalModel after flattening that is required for shade plugin to work after flattening

✅ Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

ℹ Additional Information

@piotrwielgolaski-tomtom
feat: set project.originalModel after flattening
6e0e3b0 
it is required for shade plugin
@ayoukhananov
Copy link
Contributor

@piotrwielgolaski-tomtom I will check the PR .
Want to make sure there are no regressions

@piotrwielgolaski-tomtom
Copy link
Contributor Author

@ayoukhananov any luck?

@ayoukhananov ayoukhananov merged commit c9101cf into outbrain:main Jan 23, 2023
@piotrwielgolaski-tomtom piotrwielgolaski-tomtom deleted the shade_plugin branch January 31, 2023 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG]: Problem with working with maven shaded
2 participants
@piotrwielgolaski-tomtom @ayoukhananov