Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: Problem with working with maven shaded #42

Closed
piotrwielgolaski-tomtom opened this issue Dec 13, 2022 · 5 comments · Fixed by #45
Closed

[BUG]: Problem with working with maven shaded #42

piotrwielgolaski-tomtom opened this issue Dec 13, 2022 · 5 comments · Fixed by #45
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@piotrwielgolaski-tomtom
Copy link
Contributor

piotrwielgolaski-tomtom commented Dec 13, 2022

Description of the bug

There is issue with working with this plugin when maven-shade plugin is used

Details and fix in flatten plugin is here mojohaus/flatten-maven-plugin#100

Steps To Reproduce

Use shade plugin and check if in dependency-reduced-pom.xml ${revision} is replaced

Additional Information

it seems that we lack of one extra call around https://github.com/outbrain/ci-friendly-flatten-maven-plugin/blob/main/src/main/java/com/outbrain/ci/friendly/flatten/maven/plugin/FlattenMojo.java#L57

this.project.setOriginalModel( flattenedPom );

https://github.com/mojohaus/flatten-maven-plugin/pull/281/files#diff-9f8ec1d13bc75e576b6c21b96d277373eb856d5465ef87ef675a983b3ade36beR425

@piotrwielgolaski-tomtom piotrwielgolaski-tomtom added the bug Something isn't working label Dec 13, 2022
@ayoukhananov
Copy link
Contributor

Thanks @piotrwielgolaski-tomtom
We will look into it .

@ayoukhananov ayoukhananov added the help wanted Extra attention is needed label Dec 20, 2022
@ayoukhananov
Copy link
Contributor

@piotrwielgolaski-tomtom
Can you please create a Pull Request with this change ?

@piotrwielgolaski-tomtom
Copy link
Contributor Author

@ayoukhananov I created the simplest fix, tested in my scenario and it works

@ayoukhananov
Copy link
Contributor

@piotrwielgolaski-tomtom We have few junit tests and lack of integration tests , this is the main reason it takes so long.

@ayoukhananov
Copy link
Contributor

@piotrwielgolaski-tomtom Was released with 1.0.16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
2 participants