We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
There is issue with working with this plugin when maven-shade plugin is used
Details and fix in flatten plugin is here mojohaus/flatten-maven-plugin#100
Use shade plugin and check if in dependency-reduced-pom.xml ${revision} is replaced
it seems that we lack of one extra call around https://github.com/outbrain/ci-friendly-flatten-maven-plugin/blob/main/src/main/java/com/outbrain/ci/friendly/flatten/maven/plugin/FlattenMojo.java#L57
this.project.setOriginalModel( flattenedPom );
https://github.com/mojohaus/flatten-maven-plugin/pull/281/files#diff-9f8ec1d13bc75e576b6c21b96d277373eb856d5465ef87ef675a983b3ade36beR425
The text was updated successfully, but these errors were encountered:
Thanks @piotrwielgolaski-tomtom We will look into it .
Sorry, something went wrong.
@piotrwielgolaski-tomtom Can you please create a Pull Request with this change ?
@ayoukhananov I created the simplest fix, tested in my scenario and it works
@piotrwielgolaski-tomtom We have few junit tests and lack of integration tests , this is the main reason it takes so long.
@piotrwielgolaski-tomtom Was released with 1.0.16
Successfully merging a pull request may close this issue.
Description of the bug
There is issue with working with this plugin when maven-shade plugin is used
Details and fix in flatten plugin is here mojohaus/flatten-maven-plugin#100
Steps To Reproduce
Use shade plugin and check if in dependency-reduced-pom.xml ${revision} is replaced
Additional Information
it seems that we lack of one extra call around https://github.com/outbrain/ci-friendly-flatten-maven-plugin/blob/main/src/main/java/com/outbrain/ci/friendly/flatten/maven/plugin/FlattenMojo.java#L57
https://github.com/mojohaus/flatten-maven-plugin/pull/281/files#diff-9f8ec1d13bc75e576b6c21b96d277373eb856d5465ef87ef675a983b3ade36beR425
The text was updated successfully, but these errors were encountered: