fix: support powershell constrained language mode (electron-userland#…

…7230)
ouliuquan · Nov 2, 2022 · 346af1d · 346af1d
1 parent c21e3b3
commit 346af1d
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 10 deletions.
diff --git a/.changeset/real-olives-film.md b/.changeset/real-olives-film.md
@@ -0,0 +1,5 @@
+---
+"electron-updater": patch
+---
+
+fix: support powershell constrained language mode
diff --git a/packages/electron-updater/src/windowsExecutableCodeSignatureVerifier.ts b/packages/electron-updater/src/windowsExecutableCodeSignatureVerifier.ts
@@ -31,16 +31,10 @@ export function verifySignature(publisherNames: Array<string>, unescapedTempUpda
     // https://github.com/electron-userland/electron-builder/issues/2421
     // https://github.com/electron-userland/electron-builder/issues/2535
     execFile(
-      "powershell.exe",
-      [
-        "-NoProfile",
-        "-NonInteractive",
-        "-InputFormat",
-        "None",
-        "-Command",
-        `Get-AuthenticodeSignature -LiteralPath '${tempUpdateFile}' | ConvertTo-Json -Compress | ForEach-Object { [Convert]::ToBase64String([System.Text.Encoding]::UTF8.GetBytes($_)) }`,
-      ],
+      "chcp 65001 >NUL & powershell.exe",
+      ["-NoProfile", "-NonInteractive", "-InputFormat", "None", "-Command", `"Get-AuthenticodeSignature -LiteralPath '${tempUpdateFile}' | ConvertTo-Json -Compress"`],
       {
+        shell: true,
         timeout: 20 * 1000,
       },
       (error, stdout, stderr) => {
@@ -51,7 +45,7 @@ export function verifySignature(publisherNames: Array<string>, unescapedTempUpda
             return
           }
 
-          const data = parseOut(Buffer.from(stdout, "base64").toString("utf-8"))
+          const data = parseOut(stdout)
           if (data.Status === 0) {
             const subject = parseDn(data.SignerCertificate.Subject)
             let match = false